-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove notebook templates and add basic server templates. #54
Conversation
This raises an interesting point on what to do with templates+handlers for terminals, nbconvert, the editor, etc. Each of these "extensions" reference templates, js, and css that are client application specific... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@blink1073 and @SylvainCorlay any objection to me merging this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks, Steve! |
* add basic tests for traits * fix traits to load dynamically * initial proviser tests * add initial provisioner tests * add missing undefined trait * more provisioner tests * working provisioner tests * add coverage to tests * address coverage gaps * add basic app tests * more app tests and kernelspec tests * refactor main app class to instantiate the NotebookServiceClient * minor reformatting fixes
This addresses #52 and #16.
MainHandler
to handle requests that hit the default URL.These templates are essentially just place holders. Extensions should provide their own templates.